[15.0][MIG] base_tier_validation_waiting #638

bosd · 2023-04-19T12:37:25Z

Depends on:
#732 Do not sent double messages on the first validation sequence

bosd · 2023-04-19T12:50:19Z

/ocabot migration base_tier_validation_waiting

OCA-git-bot · 2023-04-19T12:50:29Z

Sorry @bosd you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

simahawk · 2023-04-19T12:54:32Z

/ocabot migration base_tier_validation_waiting

simahawk

LG minor comments

base_tier_validation_waiting/readme/DESCRIPTION.rst

base_tier_validation_waiting/tests/test_tier_validation.py

bosd · 2023-06-22T13:15:33Z

@cwjoalder Can you please review?

bosd · 2023-06-22T20:56:31Z

@simahawk Can you review the changes? 🙏

base_tier_validation_waiting/models/tier_validation.py

bosd · 2023-08-12T20:53:33Z

Force pushed to recreate runboat

bosd · 2023-10-07T11:58:02Z

@Dranyel-Bosd Can you please review?

Dranyel-Bosd

looks so good to me 👍 🎇

base_tier_validation_waiting/tests/test_tier_validation.py

base_tier_validation_waiting/models/tier_review.py

simahawk · 2023-10-10T05:31:38Z

base_tier_validation_waiting/models/tier_review.py

+                if record.status != "waiting":
+                    continue
+                # if approve by sequence, check sequence has been reached
+                if record.approve_sequence:


I'm not sure I get this IF block: in any case you set "pending" -> can't you have 1 single check?

base_tier_validation_waiting/models/tier_review.py

base_tier_validation_waiting/models/tier_validation.py

bosd · 2023-10-23T11:57:34Z

@simahawk Thanks for your review!

I'm working my way towards more coverage and green tests 😁
Adding coverage by testing the notifications.
But it's breaking/affecting tests of other modules.
Added the fixes for those in this PR. Is that allowed/correct OCA procedure?

I've watched your talks about the unittests.
Still I'm struggling with getting how to get the tier_validation_server_action fixed.

This module is altering the behaviour by adding the state waiting, which results in breaking the tests of server action.
When this module is installed, an alternative version of tests should be run by that module. Is that correct?
Can you explain how to do that? 😊 🙏


===================================================================== 
2023-10-23 07:04:27,754 1037 ERROR odoo odoo.addons.base_tier_validation_server_action.tests.test_tier_validation: FAIL: TierTierValidation.test_1_auto_validation
Traceback (most recent call last):
  File "/__w/server-ux/server-ux/base_tier_validation_server_action/tests/test_tier_validation.py", line 100, in test_1_auto_validation
    self.assertEqual(
AssertionError: Lists differ: ['waiting', 'waiting', 'waiting'] != ['pending', 'pending', 'pending']

First differing element 0:
'waiting'
'pending'

- ['waiting', 'waiting', 'waiting']
+ ['pending', 'pending', 'pending']

DavidJForgeFlow · 2023-11-09T15:55:35Z

from odoo import api, fields, models
from odoo.tools import config


class TierReview(models.Model):
    _inherit = "tier.review"


    def _default_status(self):
        if not config["test_enable"] or config["test_enable"] and self.env.context.get("_testing_base_tier_validationwaiting"):
            self.status = "waiting"
        else:
            self.status = "pending"
        
    status = fields.Selection(
        selection_add=[("waiting", "Waiting")],
        default="_default_status",
        ondelete={"waiting": "set default"},
    )

Maybe this helps to work with the other module

Co-authored-by: Simone Orsi <simahawk@users.noreply.github.com>

Dranyel-Bosd

LGTM 👍

without this the tests of some other modules might fail, e.g. base_tier_validation_server_action. The introduced context prevents writing/patching unit tests of other base_tier_validation_* modules.

bosd · 2023-11-29T20:40:59Z

Dropped the dependency on 732. Now we finally have green tests ✔️
✨ 🎉

simahawk · 2023-11-30T08:42:06Z

base_tier_validation_waiting/models/tier_review.py



 class TierReview(models.Model):
    _inherit = "tier.review"

+    def _default_status(self):
+        if (
+            not config["test_enable"]


do we really need this specific check for tests?

Yes, without this commit, it would mean that we need to patch a lot of depending modules, to fix their tests.

Another solution I've evaluated is using seperate tests. That might solve the problem with the CI tests here on github.
But it would simply transfer the problem to the persons running an custom CI like odoo.sh.

The method here is not really clean. But it's the least dirty solution.
(Discussed this test issue with a couple of oca contributors at the OXP)
Maybe you have another insight to solve this problem?

simahawk · 2023-11-30T08:42:20Z

base_tier_validation_waiting/models/tier_review.py

    status = fields.Selection(
        selection_add=[("waiting", "Waiting")],
-        default="waiting",
+        default=_default_status,


use lambda to not reference the method object directly

github-actions · 2024-03-31T12:15:39Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

bosd force-pushed the 15.0-mig-base_tier_validation_waiting branch from 05371d2 to 1084cad Compare April 19, 2023 12:48

bosd mentioned this pull request Apr 19, 2023

Migration to version 15.0 #390

Closed

34 tasks

bosd marked this pull request as ready for review April 19, 2023 12:53

OCA-git-bot added this to the 15.0 milestone Apr 19, 2023

simahawk reviewed Apr 19, 2023

View reviewed changes

base_tier_validation_waiting/readme/DESCRIPTION.rst Show resolved Hide resolved

base_tier_validation_waiting/tests/test_tier_validation.py Outdated Show resolved Hide resolved

bosd force-pushed the 15.0-mig-base_tier_validation_waiting branch 4 times, most recently from 097e6d1 to 26c2caa Compare April 20, 2023 09:23

bosd requested a review from simahawk April 20, 2023 09:28

michaelslade54 reviewed Aug 11, 2023

View reviewed changes

base_tier_validation_waiting/models/tier_validation.py Show resolved Hide resolved

bosd force-pushed the 15.0-mig-base_tier_validation_waiting branch from 81eca93 to 26c2caa Compare August 12, 2023 20:53

bosd requested a review from michaelslade54 October 7, 2023 11:57

Dranyel-Bosd approved these changes Oct 9, 2023

View reviewed changes

simahawk requested changes Oct 10, 2023

View reviewed changes

bosd force-pushed the 15.0-mig-base_tier_validation_waiting branch 3 times, most recently from 7d8edf5 to 3c5d1ce Compare October 23, 2023 06:59

bosd force-pushed the 15.0-mig-base_tier_validation_waiting branch 2 times, most recently from 9b63c33 to 2f5281f Compare October 25, 2023 04:45

BT-jcolmeiro and others added 2 commits November 2, 2023 22:32

[ADD] base_tier_validation_waiting

6a7d9d9

[UPD] Update base_tier_validation_waiting.pot

8c93ee8

OCA-git-bot and others added 2 commits November 2, 2023 22:32

[UPD] README.rst

a890d13

[IMP] base_tier_validation_waiting: pre-commit execution

ebb81aa

bosd force-pushed the 15.0-mig-base_tier_validation_waiting branch from 2f5281f to f68e73c Compare November 2, 2023 21:35

bosd and others added 4 commits November 22, 2023 21:14

[MIG] base_tier_validation_waiting: Migration to 15.0

d49fffc

[IMP] base_tier_validation_waiting test

1ced653

Co-authored-by: Simone Orsi <simahawk@users.noreply.github.com>

[IMP] base_tier_validation_waiting: validation state w/o sequence

dc54332

[IMP] base_tier_validation_waiting: code refactor

e167045

bosd force-pushed the 15.0-mig-base_tier_validation_waiting branch from 2ee9c17 to cd6ccb0 Compare November 22, 2023 20:21

Dranyel-Bosd approved these changes Nov 23, 2023

View reviewed changes

bosd force-pushed the 15.0-mig-base_tier_validation_waiting branch 2 times, most recently from 902d294 to 4a4b26f Compare November 29, 2023 20:01

bosd added 6 commits November 29, 2023 21:06

[IMP] base_tier_validation_waiting: test notifications

462c898

[IMP] base_tier_validation: update tests to support messages

2fbae16

[IMP] base_tier_validation_forward: update tests to support messages

a0eb267

[IMP] base_tier_validation_formula: update tests to support messages

ff8b053

[IMP] base_tier_validation: use sudo to post message

4c70394

[IMP] base_tier_validation_waiting: Improve test compatibility

174337e

without this the tests of some other modules might fail, e.g. base_tier_validation_server_action. The introduced context prevents writing/patching unit tests of other base_tier_validation_* modules.

bosd force-pushed the 15.0-mig-base_tier_validation_waiting branch from 4a4b26f to 174337e Compare November 29, 2023 20:07

bosd requested a review from simahawk November 30, 2023 08:29

simahawk reviewed Nov 30, 2023

View reviewed changes

This was referenced Dec 28, 2023

[17.0][MIG] base_tier_validation: Migration to 17.0 #787

Merged

[15.0][IMP]base_tier_validation: only post notifications to reciepients #732

Closed

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 31, 2024

github-actions bot closed this May 5, 2024

bosd mentioned this pull request Aug 28, 2024

[15.0][ENH] base_tier_validation, add Notify Reviewers by Approve Sequence #854

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0][MIG] base_tier_validation_waiting #638

[15.0][MIG] base_tier_validation_waiting #638

bosd commented Apr 19, 2023 •

edited

Loading

bosd commented Apr 19, 2023

OCA-git-bot commented Apr 19, 2023

simahawk commented Apr 19, 2023

simahawk left a comment

bosd commented Jun 22, 2023

bosd commented Jun 22, 2023

bosd commented Aug 12, 2023

bosd commented Oct 7, 2023

Dranyel-Bosd left a comment

simahawk Oct 10, 2023

bosd commented Oct 23, 2023

DavidJForgeFlow commented Nov 9, 2023

Dranyel-Bosd left a comment

bosd commented Nov 29, 2023

simahawk Nov 30, 2023

bosd Nov 30, 2023

simahawk Nov 30, 2023 •

edited

Loading

github-actions bot commented Mar 31, 2024

[15.0][MIG] base_tier_validation_waiting #638

[15.0][MIG] base_tier_validation_waiting #638

Conversation

bosd commented Apr 19, 2023 • edited Loading

bosd commented Apr 19, 2023

OCA-git-bot commented Apr 19, 2023

simahawk commented Apr 19, 2023

simahawk left a comment

Choose a reason for hiding this comment

bosd commented Jun 22, 2023

bosd commented Jun 22, 2023

bosd commented Aug 12, 2023

bosd commented Oct 7, 2023

Dranyel-Bosd left a comment

Choose a reason for hiding this comment

simahawk Oct 10, 2023

Choose a reason for hiding this comment

bosd commented Oct 23, 2023

DavidJForgeFlow commented Nov 9, 2023

Dranyel-Bosd left a comment

Choose a reason for hiding this comment

bosd commented Nov 29, 2023

simahawk Nov 30, 2023

Choose a reason for hiding this comment

bosd Nov 30, 2023

Choose a reason for hiding this comment

simahawk Nov 30, 2023 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Mar 31, 2024

bosd commented Apr 19, 2023 •

edited

Loading

simahawk Nov 30, 2023 •

edited

Loading